Properly parse the vault key path

tink-crypto / tink

Tink is a multi-language, cross-platform, open source library that provides cryptographic APIs that are secure, easy to use correctly, and hard(er) to misuse.

https://developers.google.com/tink

Apache License 2.0

13.47k stars 1.18k forks source link

Properly parse the vault key path #640

Closed theory closed 1 year ago

theory commented 1 year ago

By using url.Parse. Add internal tests to test various URL formats.

Fixes #531.

juergw commented 1 year ago

I think it would be better to use "net/url" instead. Could you update this pull request? Thanks.

theory commented 1 year ago

I think it would be better to use "net/url" instead. Could you update this pull request? Thanks.

Done in 52515c2.

juergw commented 1 year ago

Looks good, there are just two small things that I missed before that should be changed:

Licence+Copyright header is missing. Could you add the same header to the new test file as all the other files have? Starting with "// Copyright 2023 Google LLC".
The last test-case is a duplicate, and doesn't have a name. Could you remove it? Thanks.

theory commented 1 year ago

Not sure how I got that dupe test case in there 🤦🏻 . Anyway, fixed in 12bd06da9.