search

tink-crypto / tink

Tink is a multi-language, cross-platform, open source library that provides cryptographic APIs that are secure, easy to use correctly, and hard(er) to misuse.
https://developers.google.com/tink
Apache License 2.0
13.47k stars 1.18k forks source link

Python requirements.txt and requirements.in don't match protobuf versions #667

Closed alecgorge closed 1 year ago

alecgorge commented 1 year ago

Describe the bug:

protobuf==4.21.9 is declared in requirements.in but the requirements.txt file still says protobuf==3.20.3

This will make it difficult for me to update tink alongside other dependencies like grpcio or grpcio-tools that declare >=4.21.6 whenever Tink 1.7.0 is released.

What was the expected behavior?

I can install grpcio-tools==1.51.1 alongside tink.

How can we reproduce the bug?

requirements.txt

grpcio==1.51.1
grpcio-tools==1.51.1
tink~=1.6.1

pip install

tholenst commented 1 year ago

Thanks, sorry about this. I made a mess there, and will take a look.

tholenst commented 1 year ago

I upgraded this to 4.21.9 everywhere. Note that Tink does not use any of the APIs which changed and I assume there is a way for you to override this.

I am not very familiar with the way these requirements work though, so let me know if this is still difficult to use.

tholenst commented 1 year ago

https://github.com/google/tink/commit/2de9ff92f13c882af427299853862afc0ba67045 should fix this.

alecgorge commented 1 year ago

forgot to respond before, but thanks for the quick turnaround on the fix :)