search

tink-crypto / tink

Tink is a multi-language, cross-platform, open source library that provides cryptographic APIs that are secure, easy to use correctly, and hard(er) to misuse.
https://developers.google.com/tink
Apache License 2.0
13.5k stars 1.18k forks source link

Upgrade C++ library to use the latest AWS SDK #677

Closed gergelykovacs closed 1 year ago

gergelykovacs commented 1 year ago

Is your feature request related to a problem?

The current C++ version of Tink 1.7 uses AWS C++ SDK version 1.7.345, see in aws kms integration

Current version of AWS C++ SDK is at 1.11.x.

There were several changes in the AWS SDK since the 1.7.x version and upgrade attempts resulted in compilation errors, e.g.,

#22 41.99 CMake Error at CMakeLists.txt:15 (add_library):
#22 41.99   Target "..." links to target "AWS::crypto" but the target was not
#22 41.99   found.  Perhaps a find_package() call is missing for an IMPORTED target, or
#22 41.99   an ALIAS target is missing?

What sort of feature would you like to see?

Could you follow up on the changes made by AWS to have a compatible version of Tink with AWS SDK 1.11.x?

Have you considered any alternative solutions?

Partial copies and overwrites were considered however not used due to maintainability problem and unintentional errors.

Would you like to add additional context?

N/A

morambro commented 1 year ago

Hi @gergelykovacs, this is something we are aware of. Unfortunately, this is not a trivial upgrade for us because we are maintaining the Bazel build rules for the SDK and dependent libraries, and between 1.7.X and 1.11.X the structure of the repo has changed significantly. Thus I don't have an ETA for this at the moment.

gergelykovacs commented 1 year ago

Thanks @morambro for the feedback!