search

tink-crypto / tink

Tink is a multi-language, cross-platform, open source library that provides cryptographic APIs that are secure, easy to use correctly, and hard(er) to misuse.
https://developers.google.com/tink
Apache License 2.0
13.47k stars 1.18k forks source link

aead/subtle: change bazel visibility to public #718

Closed derpsteb closed 9 months ago

derpsteb commented 10 months ago

Hey. Thanks for the nice library!

We want to use aead/subtle in a project that is built with Bazel. However, aead/subtle's default visibilty stops us from doing that. I understand the docs in a way that suggests using subtle pkgs is intended use; keeping in mind that extra care is required. Thus, add public visibility on the Bazel level, just like kwp/subtle does it.

Cheers.

derpsteb commented 10 months ago

Oh. I was just made aware of the fact that there also is https://github.com/tink-crypto/tink-go. So this probably goes there. I will keep this open in case you want to have it anyways, but will also open a PR over there.

juergw commented 9 months ago

For non-basel users, subtle is already public, so it should also be public for bazel users. I've now done that: https://github.com/tink-crypto/tink-go/commit/b0b39f1d46298e5e4203321f11cff166042aff1a