search

tinker-engine / sailon-protocols

0 stars 0 forks source link

Configuration reading/handling #1

Closed nrsyed closed 3 years ago

nrsyed commented 3 years ago

This PR removes the scriptconfig dependency found in the legacy sailon_client and introduces a default configuration that is updated with values from a dictionary or from a file in ONDProtocol.__init__. Because configuration handling will ultimately be the responsibility of tinker engine, the goal of this PR is only to provide a simple method for reading the existing configuration format without additional dependencies; it is not intended to be a robust means of configuration handling.

nrsyed commented 3 years ago

@waxlamp I've revamped this branch so that it imports the current iteration of tinker engine and leverages its config handling, like you suggested. This should simplify things considerably.

waxlamp commented 3 years ago

@waxlamp I've revamped this branch so that it imports the current iteration of tinker engine and leverages its config handling, like you suggested. This should simplify things considerably.

Cool. Is this ready for a review then?

nrsyed commented 3 years ago

@waxlamp I've revamped this branch so that it imports the current iteration of tinker engine and leverages its config handling, like you suggested. This should simplify things considerably.

Cool. Is this ready for a review then?

Yep, it is.