search

tinker-engine / sailon-protocols

0 stars 0 forks source link

Refactor run_protocol #17

Open nrsyed opened 3 years ago

nrsyed commented 3 years ago

This PR aims to move the per-round logic to its own method outside of run_protocol to more clearly delineate what's happening within rounds (as opposed to within tests) and to improve readability of the run_protocol method. This refactoring should not change any of the core logic or functionality.

Depends on #14.

nrsyed commented 3 years ago

@waxlamp

I'm not really qualified to review this, but the code looks ok to me at a glance.

Is there some specific insight I can provide?

Nothing specific, just wanted to check if this would make sense (or if it seems unnecessary) from a software engineering and code structure perspective.