How can tinkerbell actions handle disk/device name changes when a host has multiple disks?

ygao-armada commented 7 months ago

When a host has multiple disks, the disk names depends on the order of being detected during system boot. How to handle this in tinkerbell actions which usually depend on DEVICE/DISK name?

Expected Behaviour

There should be a stable way to define tinkerbell actions.

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

Operating System and version (e.g. Linux, Windows, MacOS):
How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
Link to your project or a code example to reproduce issue:

chrisdoherty4 commented 6 months ago

You can construct your Tinkerbell Template object to reference disks listed on the Hardware (see any example at https://github.com/tinkerbell/playground/blob/main/vagrant/template.yaml#L22).

ygao-armada commented 6 months ago

@chrisdoherty4 It may not help much, in hardware.csv, we need to use the device names, which may change, it may help if we can use the device ID in hardware.csv

chrisdoherty4 commented 6 months ago

@ygao-armada I think you're referring to EKS Anywhere's hardware CSV. For assistance with EKS Anywhere you should raise an issue on EKS Anywhere repository.

tinkerbell / actions