Fixing the issue that mkfs.xfs was not added to the base image - Githubissues

tinkerbell / actions

Suite of Tinkerbell Actions for use in Tinkerbell Workflows

Apache License 2.0

27 stars 42 forks source link

Fixing the issue that mkfs.xfs was not added to the base image #133

Open VladyslavTkachenkoDesy opened 2 months ago

VladyslavTkachenkoDesy commented 2 months ago

Description

Added mkfs.xfs support to the base image

Why is this needed

To be able to create xfs partition https://github.com/tinkerbell/actions/issues/131

Fixes: # copy to the image the mkfs.xfs command with all libs

How Has This Been Tested?

created partition with format of xfs
set action as rootio and run the installation
checked that new partition was created with format of xfs

How are existing users impacted? What migration steps/scripts do we need?

Fixes a bug

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

jacobweinstock commented 3 weeks ago

Hey @VladyslavTkachenkoDesy . Thanks for this contribution. Looks like you need to sign the DCO.

The XFS binaries here are different from the others included as they aren't statically built. Can these binaries be statically built like the others?

I also found that /sbin/fsck.xfs doesn't seem to be available.

❯ docker run -it --rm --entrypoint /sbin/fsck.xfs rootio               
exec /sbin/fsck.xfs: no such file or directory