Update Dockerfile for grub2disk:

tinkerbell / actions

Suite of Tinkerbell Actions for use in Tinkerbell Workflows

Apache License 2.0

28 stars 43 forks source link

Update Dockerfile for grub2disk: #147

Open jacobweinstock opened 2 months ago

jacobweinstock commented 2 months ago

Description

The needed packages werent installed in the final image properly.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

displague commented 1 month ago

lgtm, I was hesitant about the Docker multiple arch FROM approach, not sure that it was valid, but it is suggested here: https://stackoverflow.com/a/77726353 My initial take is inline with the linked answer, that this could be done with FROM ... {TARGETARCH} and a shell conditional for grub-bios (the only difference).

https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ is a good source for alternate approaches, many examples looking just like this one.