search

tinkerbell / actions

Suite of Tinkerbell Actions for use in Tinkerbell Workflows
Apache License 2.0
28 stars 43 forks source link

Do the equivalent of partprobe after writing in image2disk #30

Closed detiber closed 3 years ago

detiber commented 3 years ago

Description

Currently when using image2disk, if it creates new partitions on the underlying device those partitions are not accessible to following actions.

Why is this needed

This allows following actions to use any partitions created by this action.

How Has This Been Tested?

Tested manually using the steps here: https://github.com/detiber/sandbox/tree/captee

Prior to the change the workflow would fail on a newly provisioned worker, after the workflow was successful on a newly provisioned worker.

How are existing users impacted? What migration steps/scripts do we need?

This will allow users to more easily chain actions without having to insert an explicit partprobe or reboot

Checklist:

I have:

detiber commented 3 years ago

I suspect we'll need to rev the version for this change, not sure what precedent we have for that or what precedent we want to create.

gianarb commented 3 years ago

That's fine! Override it all! Dan told me that WIP means work is PERFECT! So I am merging it!! Thanks!

mmlb commented 3 years ago

That's fine! Override it all! Dan told me that WIP means work is PERFECT!

I thought it meant "Wrote It Perfectly" :p