search

tinkerbell / actions

Suite of Tinkerbell Actions for use in Tinkerbell Workflows
Apache License 2.0
28 stars 43 forks source link

Fix err check for metadata json unmarshal #34

Closed mfranczy closed 3 years ago

mfranczy commented 3 years ago

Description

Fix err check for metadata json unmarshal

Why is this needed

It is needed to see error if hw data is invalid.

Fixes: #

How Has This Been Tested?

Local setup.

How are existing users impacted? What migration steps/scripts do we need?

Users currently cannot see if there is an error related to metadata extraction.

Checklist:

I have:

gianarb commented 3 years ago

Hey @mfranczy thank you for your contribution. @thebsdbox is the person when it comes to actions!

mfranczy commented 3 years ago

@gianarb fair enough, but I don't have permissions to choose specific person as a reviewer (after the PR is open), maybe i missed something during PR creation. Sorry then.

gianarb commented 3 years ago

No problem! I know. I left a message just to explain why I changed the reviewer in this case!! Thanks a lot!!

On Tue, Mar 23, 2021 at 1:04 PM Marcin Franczyk @.***> wrote:

@gianarb https://github.com/gianarb fair enough, but I don't have permissions to choose specific person as a reviewer (after the PR is open), maybe i missed something when I opened a PR. Sorry then.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tinkerbell/hub/pull/34#issuecomment-804846718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMOAOZTOU6GCWXJATRRX5TTFB7TXANCNFSM4ZU7X4NQ .