hub should error out on errors - Githubissues

tinkerbell / actions

Suite of Tinkerbell Actions for use in Tinkerbell Workflows

Apache License 2.0

27 stars 42 forks source link

hub should error out on errors #89

Closed nshalman closed 6 months ago

nshalman commented 2 years ago

Description

As noted by @cprivitere

The go code that pushes the image doesn't properly pass the error back up the stack. So it looks like the build and push succeeded in GitHub actions when it actually failed.

This change surfaces that error.

Why is this needed

Silent failure is bad.

How Has This Been Tested?

A CI build for #87 failed properly when I added this change.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

chrisdoherty4 commented 6 months ago

Stale, we no longer use the hub cmd.