search

tinkerbell / actions

Suite of Tinkerbell Actions for use in Tinkerbell Workflows
Apache License 2.0
27 stars 42 forks source link

Extract disk wiping from disk partitioning #91

Closed moadqassem closed 1 year ago

moadqassem commented 2 years ago

Description

Extracting the Wipe functionality and add it as a dedicated command, where user can only wipe disks without any partitioning, using the metadata of the Hardware.

Why is this needed

This is very helpful, when the provisioned machine, is gonna be used by some storage specific services or SDS operator, as some of those operators don't use disks that are in a specific status(for example if the disks have partitions, the storage operator would considered this disk is being used by anther software and wouldn't use and utilize it).

Fixes: https://github.com/tinkerbell/hub/issues/90

How Has This Been Tested?

It was tested by using this commit and build an image out of it, where this image has been use as a workflow to de provision a machine.

How are existing users impacted? What migration steps/scripts do we need?

NA

Checklist:

I have:

moadqassem commented 1 year ago

@thebsdbox friendly reminder about merging this PR :)