search

tinkerbell / cluster-api-provider-tinkerbell

Cluster API Infrastructure Provider
Apache License 2.0
103 stars 36 forks source link

CAPT Playground #336

Closed jacobweinstock closed 5 months ago

jacobweinstock commented 10 months ago

Description

WIP for creating a playground in which to use, learn, and test CAPT.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

chrisdoherty4 commented 10 months ago

Looking sharp, but I do feel like we should just script this. A lot of the Go code is boilerplate around command invocations as we talked about.

jacobweinstock commented 10 months ago

Looking sharp, but I do feel like we should just script this. A lot of the Go code is boilerplate around command invocations as we talked about.

I'm open to discussing this. Here's my take. Its quite a bit nicer to work with Go for all the yaml creation than a shell script. A single binary is preferable too. I prefer working with Go around writing command, stdout, stderr to log a file than a script. For me, boilerplate in and of itself isnt a strong enough reason to move to shell. Also, this will be a good amount of code regardless of the language. I prefer to not maintaining a large amount of shell script code. I'm keen to know more from your end. Thanks!

chrisdoherty4 commented 10 months ago

@jacobweinstock Truthfully I glanced through the code and was keying off our last convo; you're in the thick of it, so if you have good reasons I'm good sticking with Go.

jacobweinstock commented 5 months ago

Going to have this be in the https://github.com/tinkerbell/playground repo instead of here. https://github.com/tinkerbell/playground/pull/191