tinkerbell / cluster-api-provider-tinkerbell

Cluster API Infrastructure Provider

Apache License 2.0

88 stars 34 forks source link

Address feedback from https://github.com/tinkerbell/cluster-api-provider-tink/pull/8 #34

Open detiber opened 3 years ago

detiber commented 3 years ago

32 was created to merge the current state of PoC work from #17, which also included changes from #8.

Feedback from #8 still needs to be reviewed and addressed.

invidian commented 3 years ago

/area tech-debt :smile:

detiber commented 3 years ago

Tried to gather links to the unaddressed feedback here, in some cases the files have moved (in particular the removal of internal directories).

invidian commented 3 years ago

48 did not address all points here.

chrisdoherty4 commented 1 year ago

This needs triaging and breaking into separate issues as needed with the intention of closing this given how old it is and reasonably significant changes to the code base.