tinkerbell / cluster-api-provider-tinkerbell

Cluster API Infrastructure Provider
Apache License 2.0
103 stars 36 forks source link

release process builds a broken infrastructure-components.yaml #344

Closed jacobweinstock closed 1 week ago

jacobweinstock commented 10 months ago

The v0.5.0 release created and uploaded to the GitHub release a broken infrastructure-components.yaml file. The are numerous creationTimestamp: "null" being created. This caused a clusterctl init command to fail with:

Error: failed to get provider components for the "tinkerbell" provider: failed to set the TargetNamespace on the components: unable to convert unstructured object to apiextensions.k8s.io/v1, Kind=CustomResourceDefinition: parsing time "null" as "2006-01-02T15:04:05Z07:00": cannot parse "null" as "2006"

I have updated the infrastructure-components.yaml from the v0.5.0 release so that creationTimestamp: "null" is now creationTimestamp: null.

This needs fixed for future releases.

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

jacobweinstock commented 1 week ago

With some local testing, this looks fixed with the latest version of kustomize (v5.5.0) that we are using.