search

tinkerbell / hegel

Instance Metadata Service
https://tinkerbell.org
Apache License 2.0
99 stars 33 forks source link

Metadata path prefix should be configurable #32

Closed displague closed 2 years ago

displague commented 4 years ago

References such as _packet/, should be configurable at runtime, as in: https://github.com/tinkerbell/hegel/blob/4e05329f4eb5bae4dde1ce7604515807f44c50f1/http_server.go#L14

The default should be _tinkerbell.

The command line, environment variables, or a configuration file would be a suitable way to pass this information. viper is one library that could accommodate all three methods.

chrisdoherty4 commented 2 years ago

How about switching to z pages instead as default? They could still be configurable but z pages seems to be the norm these days.

/healthz
/versionz
chrisdoherty4 commented 2 years ago

The /_packet endpoints have been deprecated in favor of the z pages approach common in micro services.