Have `make dev-dist` use local images:

tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows

Apache License 2.0

102 stars 49 forks source link

Have `make dev-dist` use local images: #118

Closed jacobweinstock closed 2 years ago

jacobweinstock commented 2 years ago

Description

This removes the need to push bootkit and tink-docker container images to a registry. make dev-dist will pick up locally built images and use them in the linuxkit build.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

mmlb commented 2 years ago

I don't think this does what the title says. This will just avoid linuxkit from refreshing its cache by fetching from the remote image. linuxkit does not use docker's local images. The images still need to be pushed to a remote image repository for linuxkit to retrieve them.

mmlb commented 2 years ago

Never mind this does work! @deitch you've led me astray!