search

tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
103 stars 51 forks source link

Tink worker image pull retry #122

Closed ptrivedi closed 2 years ago

ptrivedi commented 2 years ago

Description

Image pull retry for tink-worker image

Why is this needed

There could be races where linuxkit network or dns may not have been fully set up and functional yet and image pull fails because of that.

Fixes: #

Implement image pull retry loop for tink-worker image. This loop attempts an image pull every 5 seconds, upto 10 times

How Has This Been Tested?

Tested by re-running a full provisioning workflows on bare metal server and simulate image pull failures artificially to test out the retry logic.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

damdo commented 2 years ago

Looks like it has been update now, might need a re-review.

ptrivedi commented 2 years ago

@mmlb: resolved comments

ptrivedi commented 2 years ago

@mmlb: do the honors please