tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
102 stars 49 forks source link

Use better tags for bootkit and docker images #128

Closed mmlb closed 2 years ago

mmlb commented 2 years ago

Description

This will build and push images that can be tracked back to a git commit. This way we don't clobber 0.0 over and over. This also changes from 0.0 to the more common latest in docker/containers land. I did this because hook doesn't do any kind of semver anyway so might as well drop the not-meaningful 0.0. When ever we do start tagging versions here we can get back to publishing semver tags (I'd like to see latest, vX, vX.Y too for main, not sure about vX.Y.Z, but thats for another day).

Why is this needed

Helps me clean up the Makefile, and helps users to not always be fetching equivalent of latest.

How Has This Been Tested?

I've run the Makefile stuff locally, but will leave the GHA to GHA.

How are existing users impacted? What migration steps/scripts do we need?

Users will have to decide if they want to stay on latest or choose a specific sha-$COMMIT and will need to choose when to bump the image version if they choose the latter. This is only temporary as we should start tagging stuff here soon.