Fixes for #130 which was fixes for #105 - Githubissues

tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows

Apache License 2.0

102 stars 49 forks source link

Fixes for #130 which was fixes for #105 #133

Closed mmlb closed 2 years ago

mmlb commented 2 years ago

Description

Makes CI green again by avoiding attempting to push the linuxkit images via make deploy which was deleted.
Removes the dbg only binding of /etc/daemon.json which breaks hook-docker since it ends up being mounted read-only.

Why is this needed

Fixes CI and dbg runs.

How Has This Been Tested?

CI fix should just work.

I've been running with the daemon.json drop in a different branch and thought it was in branch for #130.

How are existing users impacted? What migration steps/scripts do we need?

CI is :heavy_check_mark: not :x: which makes us all feel warm and fuzzy.

dbg builds are actually useful and work.