Skip downloading the cert if tinkServerTLS is not enabled - Githubissues

tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows

Apache License 2.0

102 stars 49 forks source link

Skip downloading the cert if tinkServerTLS is not enabled #140

Closed abhinavmpandey08 closed 1 year ago

abhinavmpandey08 commented 2 years ago

Description

Skip downloading the cert if tinkServerTLS is not enabled

Why is this needed

New Tinkerbell stack doesn't host the cert anymore. I'm making it optional so it allows users to skip this process without breaking compatibility

Fixes: #

How Has This Been Tested?

Setup hook with tinkServerTLS to false and ensured that the cert doesn't get pulled

How are existing users impacted? What migration steps/scripts do we need?

Shouldn't affect existing users but they can set this flag explicitly to download/skip cert download

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

jacobweinstock commented 1 year ago

This functionality now exist in main via https://github.com/tinkerbell/hook/pull/150