tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
102 stars 49 forks source link

Add Cisco drivers #144

Closed ptrivedi closed 1 year ago

ptrivedi commented 1 year ago

Description

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

jacobweinstock commented 1 year ago

@mergifyio update

mergify[bot] commented 1 year ago

update

☑️ Nothing to do

- [ ] `#commits-behind>0` [:pushpin: update requirement] - [X] `-closed` [:pushpin: update requirement]
jacobweinstock commented 1 year ago

Hey @ptrivedi, looks like the validation check doesn't run for changes in kernel/ directory.

Would you mind, maybe, fixing this spelling mistake here, so that the validation check will run? I will open a issue for this validation check being required for kernel/ directory changes.

jacobweinstock commented 1 year ago

issue https://github.com/tinkerbell/hook/issues/145 opened.

ptrivedi commented 1 year ago

Hey @ptrivedi, looks like the validation check doesn't run for changes in kernel/ directory.

Would you mind, maybe, fixing this spelling mistake here, so that the validation check will run? I will open a issue for this validation check being required for kernel/ directory changes.

Sure thing

thebsdbox commented 1 year ago

Nice work!