tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
102 stars 49 forks source link

Add proxy support for hook-bootkit and hook-docker #162

Closed panktishah26 closed 1 year ago

panktishah26 commented 1 year ago

Description

Add support for pulling docker images and specifically the tink-worker image via a proxy by configuring appropriate proxy variables via Boots.

Why is this needed

Currently a user cannot use a proxy to pull tink-worker and container images for workflows. This PR enables proxy support for this. A user will have to pass HTTP_PROXY, HTTPS_PROXY and NO_PROXY to Boots as cli args or environment variables. These values in Boots, extra kernel args, get populated in Hook's /proc/cmdline file. hook-bootkit and hook-docker will pick up those variables and set them as an environment variables in order to pull tink-worker and workflow images from a proxy server.

Fixes: #

How Has This Been Tested?

I have tested this changes by creating a cluster on baremetal machines using the proxy settings.

How are existing users impacted? What migration steps/scripts do we need?

No changes are required for existing user.

Checklist:

I have: