search

tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
102 stars 49 forks source link

Make linuxkit Hook services resilient so that the getty always comes up: #175

Closed jacobweinstock closed 1 year ago

jacobweinstock commented 1 year ago

Description

Hook-bootkit requires a network connection to pull down the tink-worker image. The previous solution was to make sure networking was up and running via a DHCP client in the linuxkit "onboot" section. This meant that any issues with the DHCP onboot container would cause the getty, and all services, to never start. This made troubleshooting nearly impossible.

This PR makes Hook-bootkit (and hook-docker) retry all failures. This allows us to remove the DHCP "onboot" container. This should allow the getty service to always start.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

jacobweinstock commented 1 year ago

Hey @chrisdoherty4 , thanks for the review. JFYI, this is just a refactor step. There is still much more work to be done. I will follow in the future with more refactoring.