tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
101 stars 48 forks source link

KConfig_amd64 uses arm64 architecture instead #204

Closed ikyrycho closed 3 weeks ago

ikyrycho commented 5 months ago

Kernel/Makefile has a typo and uses arm64 instead of amd64

Expected Behaviour

https://github.com/tinkerbell/hook/blob/main/kernel/Makefile#L277 should use --platform=amd64 architecture in both cases.

Current Behaviour

https://github.com/tinkerbell/hook/blob/main/kernel/Makefile#L286 is using arm64 architecture for target that has amd64 in it's name.

Context

amd64 container is trying to build arm64 container, which leads to errors during container building, because all bash commands are failing

jacobweinstock commented 3 weeks ago

Thank you for reporting this. Apologies for the delayed response. The build process has been completely overhauled. This file doesn't exist anymore.