tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
107 stars 52 forks source link

Updates: #217

Closed jacobweinstock closed 6 months ago

jacobweinstock commented 6 months ago

Description

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

chrisdoherty4 commented 6 months ago

What was the motivation for finer version control over runc and containerd?

jacobweinstock commented 6 months ago

What was the motivation for finer version control over runc and containerd?

Upstream moves a bit slow for me 😬 , in terms of getting to the latest versions. These additions were helpful in my troubleshooting but im not against removing them entirely if you have some concerns. There's enough trade-offs both ways for me to be fine with either approach.

chrisdoherty4 commented 6 months ago

Presumably you mean upstream linuxkit, not upstream containerd? I.e. you're not trying to get some edge patch from containerd?

Assuming its linuxkit, I'm good with building given we're using official release tags/commits.

jacobweinstock commented 6 months ago

Presumably you mean upstream linuxkit, not upstream containerd? I.e. you're not trying to get some edge patch from containerd?

Assuming its linuxkit, I'm good with building given we're using official release tags/commits.

Yeah, upstream linuxkit.