tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows
Apache License 2.0
101 stars 48 forks source link

Push container images properly: #223

Closed jacobweinstock closed 3 months ago

jacobweinstock commented 3 months ago

Description

Because of the way CI is built (2 self-hosted runners), CI was not pushing container images when building on main. This was because PR's would build the images and the would be locally in the Docker cache. Then when main ran, hook-lk containers.sh would run and see that the image existed in the local Docker cache already and stop before pushing.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have: