build: gha: actions/checkout: don't clean working copy & fetch full history from git

tinkerbell / hook

In-memory Operating System Installation Environment for Executing Tinkerbell Workflows

Apache License 2.0

101 stars 48 forks source link

build: gha: actions/checkout: don't clean working copy & fetch full history from git #231

Closed rpardini closed 1 month ago

rpardini commented 2 months ago

build: gha: actions/checkout: don't clean working copy & fetch full history from git

instead of cleaning the whole working copy, clean out just the out and dist dirs
this allows the cache/ dir to survive on-disk on self-hosted runners
bonus: using fetch-depth: 0 allows for much faster git fetch times on self-hosted runners over time
this is done only for the jobs that can run in self-hosted runners (not prep/release jobs)

Signed-off-by: Ricardo Pardini ricardo@pardini.net

rpardini commented 2 months ago

Altenative to https://github.com/tinkerbell/hook/pull/230

jacobweinstock commented 2 months ago

Thanks for this @rpardini , both this a #230 are very reasonable. I think i'm more in favor of #230. Let's use that one and see how it goes. Thanks for looking into this!

rpardini commented 1 month ago

Hey @jacobweinstock I haven't followed up, but it looks to me #230 was good enough? If so I'll close this....

jacobweinstock commented 1 month ago

Hey @jacobweinstock I haven't followed up, but it looks to me #230 was good enough? If so I'll close this....

Hey @rpardini. Yeah, we should be good for now, thanks!