Issue with latest builds of iPXE on Mellanox ConnectX

[nshalman]

Current status

This is a ticket for tracking issues related to ipxe/ipxe#1091

There is a simple undef workaround that we can ship in our configuration until the upstream bug is fully resolved: https://github.com/ipxe/ipxe/issues/1091#issuecomment-1946152615

#undef NET_PROTO_EAPOL

We should ship that workaround until the upstream issue is resolved.

Original report

This is a ticket for tracking issues related to ipxe/ipxe#1091 For additional reference, netbootxyz/netboot.xyz#1359

Basically Equinix Metal is blocked on updating ipxedust because the latest builds of ipxe don't work on a bunch of our currently deployed fleet.

I have tested https://github.com/nshalman/ipxe/commit/fbc3b4a104698658202c2a83217ca8722453bf49 as a revert of https://github.com/ipxe/ipxe/commit/8b14652e506d99499cfbeaed0df07d6a83ec029e

Ideally this ticket will remain open until ipxe/ipxe#1091 is fixed properly. One option for now is to ship the revert in ipxedust and keep applying the revert until a proper fix lands. Otherwise I can maintain a fork for Equinix in the meantime.

But I do imagine other consumers of ipxedust with similar hardware will run into a similar issue in the meantime...

I intend to open a PR that would ship the revert, but I completely understand if the tinkerbell project chooses not to merge it.

[nshalman]

https://github.com/ipxe/ipxe/issues/1091#issuecomment-1946152615 suggests we could probably get away with an undef instead of needing a patch.

[nshalman]

ipxe/ipxe#1091 (comment) suggests we could probably get away with an undef instead of needing a patch.

Tested and appears to work.