search

tinkerbell / ipxedust

TFTP, HTTP library, and CLI server for serving iPXE binaries
Apache License 2.0
21 stars 26 forks source link

Update to latest iPXE #142

Closed nshalman closed 6 months ago

nshalman commented 6 months ago

Description

Update to the latest iPXE

This release includes https://github.com/ipxe/ipxe/pull/1152 which resolves #117.

I've also included the workaround for #115 as specified from https://github.com/ipxe/ipxe/issues/1091#issuecomment-1946152615 to keep Mellanox cards working.

Why is this needed

Fixes: #117 Relates to: #115

How Has This Been Tested?

I am drafting this PR as the first step towards testing. The plan is:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.82%. Comparing base (36ad044) to head (62314e0). Report is 20 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ========================================== + Coverage 97.28% 97.82% +0.53% ========================================== Files 5 5 Lines 442 367 -75 ========================================== - Hits 430 359 -71 + Misses 8 4 -4 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nshalman commented 6 months ago

Forgot to revert the patching in of the certificates... Need a bit more testing to confirm and will update this PR.

nshalman commented 6 months ago

Let me know if you want the changes in 7f6cde108b3d7706fd854586ac30b517f36f7289 split into more than one commit. I will sadly also have a follow up issue to file related to https://github.com/ipxe/ipxe/issues/1115 and a follow up PR akin to what we did for the Mellanox issue, but at least we can still still stick to only a single ipxe revert commit now that there is a better workaround for the Mellanox EAPOL issue.