tinkerbell / k8s-sandbox

The easiest way to setup the Tinkerbell Stack on Kubernetes
Apache License 2.0
9 stars 9 forks source link

Allow services to run on both Vagrant and kind using the same manifests #7

Closed mrchrd closed 3 years ago

mrchrd commented 3 years ago

Description

This allows manifests to be deployed in either the normal Vagrant sandbox or Kind, using KubeVirt.

Why is this needed

This is a step forward to standardize deployment in Kubernetes. While k8s-sandbox is useful to test real-life scenarios, https://github.com/detiber/tink/tree/kindDev is great for development. By merging the two repositories, the idea is to make development and "prod" environments as similar as possible.

How Has This Been Tested?

Both vagrant_test.go and the new kind_test.go ran successfully, and also validated manually that the hello-world pipeline works.

How are existing users impacted? What migration steps/scripts do we need?

N/A

Checklist:

I have:

thebsdbox commented 3 years ago

This is excellent! Thanks so much for your hardwork!