search

tinkerbell / lint-install

Consistently install reasonable linter rules for open-source projects
Apache License 2.0
6 stars 7 forks source link

Enable gofumpt and gosec #14

Closed tstromberg closed 3 years ago

tstromberg commented 3 years ago

Fixes #11

This also enables gosec now that the false positives have been tuned down a bit.

tstromberg commented 3 years ago

@mmlb - no, but considering it more after your other code review, I felt like the consistency is more important than the output.

The best we can do with gofumpt is show output that says "There is a diff", which is effectively what this linter does today. What I would rather it say is "There is an unnecessary empty line: run gofumpt to fix it".

The nice part about integrating it here is that golangci-lint run --fix will now fix gofumpt issues.