search

tinkerbell / lint-install

Consistently install reasonable linter rules for open-source projects
Apache License 2.0
6 stars 7 forks source link

Relax lint checks on autogenerated protobuf packages #23

Open tstromberg opened 2 years ago

tstromberg commented 2 years ago

This was raised by a comment from @displague

Off the top of my head, the only linter I can think that this might impact is the gofumpt checker.

mmlb commented 2 years ago

I lean towards not doing this. I'd rather have the go:generate step run goimports/gofumpt. I find it easier to avoid snowflakes.

displague commented 2 years ago

If the make tasks (fmt,fix,gen?) do the right thing, and the contributing guides say as much, I don't think we would need to bog down the Go generator process or reduce the linter levels.