tinkerbell / lint-install

Consistently install reasonable linter rules for open-source projects
Apache License 2.0
6 stars 7 forks source link

Allow linters to run concurrently #33

Closed mmlb closed 2 years ago

mmlb commented 2 years ago

Description

The main reason for this PR is to use make's concurrency features to run the lint/fix commands instead of doing so serially. The reason for wanting this is to be able to run make --keep-going lint so that we can see the errors for all linters instead of just one at a time, while still having make return an error exit if one of the linters did in fact fail.

There were some clean up/extras/fixes along the way including:

Why is this needed

The reason for wanting this is to be able to run make --keep-going lint so that we can see the errors for all linters instead of just one at a time, while still having make return an error exit if one of the linters did in fact fail.

How Has This Been Tested?

I've run this locally, including make fix.

How are existing users impacted? What migration steps/scripts do we need?

Less run-fix-check cycles since more of the errors are going to show up at once. Newer linters with possibly better checks.

mmlb commented 2 years ago

Thanks for bringing up the hash/verification issue @stephen-fox I've opened up #34 instead of piling up on this PR for this.