search

tinkerbell / lint-install

Consistently install reasonable linter rules for open-source projects
Apache License 2.0
6 stars 7 forks source link

golangci-lint multi-module: Use $CURDIR to pin down execdir #40

Closed tstromberg closed 2 years ago

tstromberg commented 2 years ago

Signed-off-by: Thomas Stromberg t+github@chainguard.dev

Description

Fixes broken behavior with repositories containing multiple go packages. This change ensures that the successive find command are able to locate the path to golangci-lint properly.

Why is this needed

Fixes: #39

How Has This Been Tested?

Ran make golangci-lint-lint in a repo containing ~40 go packages

mmlb commented 2 years ago

Hey @tstromberg I've opened up #45 with my version of these fixes. I also noticed that in multi-module mode no config file is actually used so fixed that too. I say lets go with #45 over this one, wdyt?