Fix golangci-lint linter when multiple modules exist - Githubissues

tinkerbell / lint-install

Consistently install reasonable linter rules for open-source projects

Apache License 2.0

6 stars 7 forks source link

Fix golangci-lint linter when multiple modules exist #45

Closed mmlb closed 2 years ago

mmlb commented 2 years ago

Description

Uses full paths to executables, so changed dirs don't matter
Switches to always using find -execdir to run golangci-lint to avoid an seldomly used corner case bit rotting
Uses the correct variable name for the golangci-lint config file

Why is this needed

Fixes: #39 Closes: #40

How Has This Been Tested?

Ran make lint a bunch in hook to make sure it works.

How are existing users impacted? What migration steps/scripts do we need?

golangci-lint will actually run if multiple modules are detected (or added w/o having to re-run lint-install).