tinkerbell / osie

An in-memory installation environment for bare metal.
https://tinkerbell.org
Apache License 2.0
99 stars 30 forks source link

Include the asrockrack bios kernel module #284

Closed joelrebel closed 2 years ago

joelrebel commented 2 years ago

Description

This change updates the alpine image to build and include the asrdev.ko kernel module, which enables the Asrockrack BIOS utility BIOSControl to set/get BIOS configuration.

Why is this needed

To export and import BIOS configuration on the Asrockrack hardware.

How Has This Been Tested?

By building the Alpine docker image

mmlb commented 2 years ago

Hey @joelrebel the zip file should be added to lfs, not directly to git do you have git lfs installed and enabled? You'll need to do something like git lfs track installer/alpine/*.zip so the git magic can happen.

ScottGarman commented 2 years ago

Also, just one trivial change will get the ci-checks build step to pass:

--- installer/alpine/build.sh.orig
+++ installer/alpine/build.sh
@@ -7,7 +7,7 @@

 build_initramfs() {
    # Asrockrack kernel module
-   cat > /etc/mkinitfs/features.d/asrockrack.modules <<-EOF
+   cat >/etc/mkinitfs/features.d/asrockrack.modules <<-EOF
        extra/asrdev.ko
    EOF
joelrebel commented 2 years ago

Oh right, I created a new branch with the file in Git LFS instead, PR here https://github.com/tinkerbell/osie/pull/286, will close this one