tinkerbell / osie

An in-memory installation environment for bare metal.
https://tinkerbell.org
Apache License 2.0
99 stars 30 forks source link

apps/osie-installer: Configure docker /w syslog log driver #290

Closed splaspood closed 2 years ago

splaspood commented 3 years ago

Description

Configures the alpine local docker to use the 'syslog' logging driver via boots (as derived from the syslog_host kopt).

Why is this needed

We would like to collect osie-runner output in our central logging systems alongside the rest of the log output from our various services. (boots, hegel, etc)

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Once osie's alpine environment has been upgraded to 3.14 it should include a docker capable of 'dual logging' which will allow 'docker logs' to continue working as it would before this change.

Checklist:

I have:

jacobweinstock commented 3 years ago

This seems reasonable. Does anyone else have any concerns or feedback? @mmlb @ScottGarman

stephen-fox commented 2 years ago

With the deprecation of OSIE, we will (likely) make this change to Metal's internal fork. It just needs to be re-proposed there.