tinkerbell / pbnj

Service for interacting with BMCs
Apache License 2.0
103 stars 35 forks source link

Refactor `SetPower` to be test-able #106

Open jacobweinstock opened 2 years ago

jacobweinstock commented 2 years ago

The PowerSet method is over 100 lines of code, core to the functionality of PBnJ, and not tested. This is dangerous, as seen in #105. We should refactor SetPower and BootDeviceSet to be test-able.

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

mmlb commented 2 years ago

Moved to longterm as its not getting any work done soon it seems :D