search

tinkerbell / pbnj

Service for interacting with BMCs
Apache License 2.0
109 stars 37 forks source link

Revert "convert StringSlice attributes to Strings for now" #126

Closed nshalman closed 2 years ago

nshalman commented 2 years ago

Description

Dear reader, the world has changed. https://github.com/honeycombio/husky/pull/17 has been merged.

Why is this needed

Reverts #109 / 3581292 as the underlying issue has been fixed for honeycomb.

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

codecov[bot] commented 2 years ago

Codecov Report

Merging #126 (0148f8f) into main (8b6ce7e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 0148f8f differs from pull request most recent head 9508342. Consider uploading reports for the commit 9508342 to get more accurate results

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files           8        8           
  Lines         435      435           
=======================================
  Hits          375      375           
  Misses         47       47           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b6ce7e...9508342. Read the comment docs.

nshalman commented 2 years ago

I want to do some manual testing before we merge this. Thanks!

nshalman commented 2 years ago

In the Honeycomb UI bmc.open.providersAttempted looks like Before this change: [ipmitool *asrockrack.ASRockRack goipmi gofish idrac9] After this change: ["gofish","ipmitool","*asrockrack.ASRockRack","idrac9"]