Revert "Try Redfish first when communicating with a BMC:"

[joelrebel]

Description

This reverts commit 32e7bbd9774f598c9e86b6729fca30b10bd18ee2.

Some redfish implementations are buggy and while being compatible they incorrectly report their power status (ASRRs E3C246D4I-NL) until we're a bit more confident that various redfish implementation behave as expected lets go with IPMI being attempted first.

https://github.com/bmc-toolbox/bmclib/blob/master/client.go#L104

If theres a pressing need to have redfish attempted first the change can be pushed down into bmclib to ignore redfish on the ASRRs although this does not seem like an ideal solution at the moment.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

This should have no negative impact on existing users.

Checklist:

I have:

• [ ] updated the documentation and/or roadmap (if required)
• [ ] added unit or e2e tests
• [ ] provided instructions on how to upgrade

[codecov[bot]]

Codecov Report

Merging #127 (4bb08fa) into main (ba908ba) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files           8        8           
  Lines         435      435           
=======================================
  Hits          375      375           
  Misses         47       47           
  Partials       13       13           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba908ba...4bb08fa. Read the comment docs.