joelrebel commented 2 years ago

Description

Enable compatible bmclib providers to manage user accounts, instead of just redfish.
Update bmclib dependency which includes various fixes, https://github.com/bmc-toolbox/bmclib/releases/tag/v0.5.3 https://github.com/bmc-toolbox/bmclib/pull/277

Why is this needed

The previous release limited user account management to redfish.

Fixes: #

How Has This Been Tested?

Tested user account creation on Dell Idrac9s and Asockrack hardware.

How are existing users impacted? What migration steps/scripts do we need?

No impact expected.

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

codecov[bot] commented 2 years ago

Codecov Report

Merging #128 (11888fe) into main (132a738) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 11888fe differs from pull request most recent head 110888f. Consider uploading reports for the commit 110888f to get more accurate results

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files           8        8           
  Lines         435      435           
=======================================
  Hits          375      375           
  Misses         47       47           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 132a738...110888f. Read the comment docs.

nshalman commented 2 years ago

@joelrebel if you have a moment to rebase this to make sure it gets applied correctly, that would be great.

tinkerbell / pbnj

Compatible bmclib providers to manage user accounts #128