nshalman commented 2 years ago

Description

Create client.Thing spans in bmc.go functions that do the heavy lifting.

Why is this needed

Fixes: #122

How Has This Been Tested?

[x] Manually

How are existing users impacted? What migration steps/scripts do we need?

If you're sending otel spans, now you'll send more.

Checklist:

I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

codecov[bot] commented 2 years ago

Codecov Report

Merging #129 (03b7ff1) into main (34853cd) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   86.20%   86.23%   +0.03%     
==========================================
  Files           8        8              
  Lines         435      436       +1     
==========================================
+ Hits          375      376       +1     
  Misses         47       47              
  Partials       13       13

Impacted Files	Coverage Δ
grpc/rpc/bmc.go	`92.00% <100.00%> (+0.08%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34853cd...03b7ff1. Read the comment docs.