tinkerbell / pbnj

Service for interacting with BMCs
Apache License 2.0
109 stars 37 forks source link

updates bmclib dependency to v2 latest #137

Closed joelrebel closed 1 year ago

joelrebel commented 1 year ago

https://github.com/bmc-toolbox/bmclib#versions https://github.com/bmc-toolbox/bmclib/pull/280#issuecomment-1163150500

Description

Updates the bmclib dependency to v2 latest.

Why is this needed

bmclib v2 is the current version which is maintained and gets features, the current version includes various Redfish related fixes and improved error handling.

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Users should have no direct impact.

Checklist:

I have:

codecov[bot] commented 1 year ago

Codecov Report

Merging #137 (021d126) into main (5de8772) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 021d126 differs from pull request most recent head ee702ae. Consider uploading reports for the commit ee702ae to get more accurate results

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files           8        8           
  Lines         436      436           
=======================================
  Hits          376      376           
  Misses         47       47           
  Partials       13       13           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

joelrebel commented 1 year ago

force pushed to include Sign off in commit