Closed joelrebel closed 1 year ago
Thanks for the feedback here @mmlb , latest changes includes the fixes.
Merging #141 (6d8073c) into main (a6b3ad1) will decrease coverage by
0.97%
. The diff coverage is16.66%
.:exclamation: Current head 6d8073c differs from pull request most recent head 72a14cb. Consider uploading reports for the commit 72a14cb to get more accurate results
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 85.87% 84.90% -0.97%
==========================================
Files 8 8
Lines 439 444 +5
==========================================
Hits 377 377
- Misses 49 54 +5
Partials 13 13
Impacted Files | Coverage Δ | |
---|---|---|
grpc/oob/common.go | 90.38% <0.00%> (-9.62%) |
:arrow_down: |
grpc/server.go | 88.13% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@jacobweinstock could you take another look here. I've added a few more fixes to update to Go 1.20, linter 1.52.2 releases.
I came across issues with linter 1.50 being hung with newer Go versions and decided to update all to the current.
Description
bmcTimeout
value from 15s to 120s.Why is this needed
How Has This Been Tested?
r640
,r6515
, SMCs, ASRR hardware.How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: