tinkerbell / pbnj

Service for interacting with BMCs
Apache License 2.0
109 stars 37 forks source link

Updates to latest bmclib #143

Closed joelrebel closed 1 year ago

joelrebel commented 1 year ago

Description

The current bmclib has various improvements and fixes that would be worth including in PBnJ.

Why is this needed

How Has This Been Tested?

Tested on a few Dell, SMC, ASRR hardware

How are existing users impacted? What migration steps/scripts do we need?

No direct impact expected.

Checklist:

I have:

codecov[bot] commented 1 year ago

Codecov Report

Merging #143 (334d257) into main (e084f63) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 334d257 differs from pull request most recent head a975b96. Consider uploading reports for the commit a975b96 to get more accurate results

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files           8        8           
  Lines         444      444           
=======================================
  Hits          377      377           
  Misses         54       54           
  Partials       13       13           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more