tinkerbell / pbnj

Service for interacting with BMCs
Apache License 2.0
109 stars 37 forks source link

Add determinism #145

Open jacobweinstock opened 1 year ago

jacobweinstock commented 1 year ago

Description

Add deterministic behavior for calls against a single host. By queuing requests per host we now provide deterministic behavior of calls.

Why is this needed

Fixes: #130

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

codecov[bot] commented 1 year ago

Codecov Report

Merging #145 (67adac7) into main (67fadb3) will decrease coverage by 1.95%. The diff coverage is 72.36%.

:exclamation: Current head 67adac7 differs from pull request most recent head 73de1b2. Consider uploading reports for the commit 73de1b2 to get more accurate results

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   81.33%   79.38%   -1.95%     
==========================================
  Files           9       11       +2     
  Lines         466      587     +121     
==========================================
+ Hits          379      466      +87     
- Misses         74      104      +30     
- Partials       13       17       +4     
Files Changed Coverage Δ
grpc/taskrunner/manager.go 60.97% <60.97%> (ø)
grpc/taskrunner/taskrunner.go 67.46% <71.42%> (+4.30%) :arrow_up:
grpc/taskrunner/run.go 74.41% <74.41%> (ø)
grpc/server.go 83.58% <75.00%> (-4.95%) :arrow_down:
grpc/rpc/bmc.go 92.00% <100.00%> (ø)
grpc/rpc/machine.go 92.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more