codecov[bot]
commented
12 months ago Codecov Report
Attention: 35 lines in your changes are missing coverage. Please review.
Comparison is base (
c15e8a7) 81.87% compared to head (0c56e5f) 77.03%.
| Files | Patch % | Lines |
|---|---|---|
| grpc/rpc/diagnostic.go | 28.57% | 35 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #151 +/- ## ========================================== - Coverage 81.87% 77.03% -4.84% ========================================== Files 9 9 Lines 491 540 +49 ========================================== + Hits 402 416 +14 - Misses 75 110 +35 Partials 14 14 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR adds in the newly added System Event Log (SEL) capture support added in bmclib.
How Has This Been Tested?
Tested against a couple of different servers for both opinionated structured and the raw capture methods with success.
How are existing users impacted? What migration steps/scripts do we need?
New methods are available to expose the SEL capture functionality added in bmclib. Two new gRPC endpoints are available:
Diagnostic/GetSystemEventLog - returns an opinionated format of the SEL consisting of a list of id,timestamp,description,message Diagnostic/GetSystemEventLogRaw - returns a raw dump of the SEL, so that the requestor may parse as they please.
Checklist:
I have: