Closed zevweiss closed 10 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
5660359
) 81.87% compared to head (ed39ec9
) 82.29%.
Files | Patch % | Lines |
---|---|---|
grpc/rpc/bmc.go | 91.30% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Updated to use new 2.2.1 tag of bmclib instead of a commit hash.
Description
These patches add a DeactivateSOL request to the grpc API, which terminates an active SOL session for a given server using the method of the same name recently added to bmclib.
Why is this needed
Active SOL sessions may at times need to be forcefully ended so as to enforce proper access control.
How Has This Been Tested?
I started an an SOL session through a local BMC via
ipmitool sol activate
and a pbnj service viago run main.go server
. Upon usingevans
to call theDeactivateSOL
method, I observed that the SOL session was successfully terminated.How are existing users impacted? What migration steps/scripts do we need?
There should be no impact to existing users, as no existing behavior is changed.
Checklist:
I have: